Skip to content

Conversation

@IgorA100
Copy link
Contributor

@IgorA100 IgorA100 commented Jul 26, 2025

There are still some changes that need to be made to the BD:
ALTER TABLE `Monitors` ADD `WhatDisplay` enum('OnlyVideo','OnlyAudioVisualization','VideoAudioVisualization') NOT NULL DEFAULT 'OnlyVideo' AFTER `Decoding`;

@IgorA100
Copy link
Contributor Author

Watch page
1111

Monitor page
1112

Will these names be ok or do I need to change something?

@connortechnology
Copy link
Member

I guess it's ok. I would have gone with a toggle for video and a toggle for analysis, but either way gets the job done.

@IgorA100
Copy link
Contributor Author

I would have gone with a toggle for video and a toggle for analysis,

Yes, I wanted to do it that way.
But, for example, for the Monitor page we will have to add another field to the DB to disable ZMS JPEG, for example "ZMSEnabled".
I have some sketches. For example, it could look like this:
1
2
3

This is a multi select in which you can select the necessary players or disable them all.
The checkboxes will be in the "disabled" state, but the "tick" will be automatically checked or unchecked depending on whether the player is selected in the multi select or not.
If you agree, I will do this as a separate PR.

@IgorA100
Copy link
Contributor Author

I would have gone with a toggle for video

I've done a lot already, but... I came to the conclusion that Player = None is wrong. To play only audio, we still need a player. It can be either go2rtc or rtsp2web.
We can't turn off the player completely, because in this case nothing will be played at all.
I'll have to stop at the option: #4393 (comment)
I can make a PR regarding this switch #4393 (comment)
But without the "None" option. Should I make a PR or leave everything as it is now?

@connortechnology
Copy link
Member

Let's leave the player issues aside. I disagree with adding options to disable zms playback, as that is the fallback when all else fails. People get confused when there are too many options to configure.
I think for now this PR should simply add the Show audio visualisation feature. Leave the rest for another day.
I am targetting Christmas for release now, so we could get this in soon.

@IgorA100
Copy link
Contributor Author

IgorA100 commented Nov 2, 2025

I disagree with adding options to disable zms playback,

I don't want to disable ZMS either.
I'm just busy with my main job right now and have put off working on this PR for a bit.
But I hope to finish this PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants